Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditioning set area can't be used in all cases #58

Open
erosDiffusion opened this issue Sep 18, 2024 · 1 comment
Open

conditioning set area can't be used in all cases #58

erosDiffusion opened this issue Sep 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@erosDiffusion
Copy link
Owner

erosDiffusion commented Sep 18, 2024

as a user
I would like to use the outputs
with set area

however there are 3 issues:

  • x,y,w,h need from transforms output to be integers (precision is limited) / movement might need to be constrained to int (no floats)
  • as the canvas is bigger so the location of the assets can be outside the rendering area but needs to be inside (no negative location and assets are alloewed and would need to be cropped - it's a little harder)
  • the integer value need to be in steps of 8 ... ?
@erosDiffusion erosDiffusion added the bug Something isn't working label Sep 18, 2024
@erosDiffusion erosDiffusion self-assigned this Sep 18, 2024
@erosDiffusion erosDiffusion changed the title conditioning set area can't be used conditioning set area can't be used in al cases Sep 18, 2024
@erosDiffusion
Copy link
Owner Author

point 1 is addressed in v3.1.0 #61

@erosDiffusion erosDiffusion moved this from Todo to In Progress in @erosDiffusion's ComfyUI Compositor Sep 21, 2024
@erosDiffusion erosDiffusion changed the title conditioning set area can't be used in al cases conditioning set area can't be used in all cases Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant