Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiblockControllerBase.hasBlock() is always false #8

Open
mezz opened this issue Jun 29, 2015 · 2 comments
Open

MultiblockControllerBase.hasBlock() is always false #8

mezz opened this issue Jun 29, 2015 · 2 comments

Comments

@mezz
Copy link

mezz commented Jun 29, 2015

https://github.com/erogenousbeef/BeefCore/blob/master/src/main/java/erogenousbeef/core/multiblock/MultiblockControllerBase.java#L95-L102

/**
 * Check if a block is being tracked by this machine.
 * @param blockCoord Coordinate to check.
 * @return True if the tile entity at blockCoord is being tracked by this machine, false otherwise.
 */
public boolean hasBlock(CoordTriplet blockCoord) {
    return connectedParts.contains(blockCoord);
}

connectedParts is a Set<IMultiblockPart> but this method is checking if it contains a CoordTriplet.

I don't think it's used in BigReactors either, so maybe it should be removed.

(I'm toying with making Forestry Multiblocks use BeefCore)

@sameer
Copy link

sameer commented Dec 12, 2015

Did you test this with a debugging statement?

@mezz
Copy link
Author

mezz commented Dec 12, 2015

There's nothing to test really, CoordTriplet != IMultiblockPart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants