Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports are not used #3

Open
CryZe opened this issue May 25, 2019 · 2 comments
Open

Exports are not used #3

CryZe opened this issue May 25, 2019 · 2 comments

Comments

@CryZe
Copy link

CryZe commented May 25, 2019

It seems like the compiler completely ignores the exports section, leading to quite a lot of functions missing in my code. This is because they actually have the same function body and LLVM (or the linker, not sure) deduplicates them. However that single remaining function is then exported with both names to the user. wasm2cil does not look at the export section at all it seems and simply exports all functions with their internal name, leading to one or more of my functions missing each.

@CryZe
Copy link
Author

CryZe commented May 27, 2019

I kind of hacked something together. It's not clean, but I guess I can open a PR for it later. I have some other PRs coming up too.

@ericsink
Copy link
Owner

During development, I often run things in this "mode", ignoring the exports section and pretending that everything is exported with its internal name.

But yes, to actually use wasm2cil, that behavior is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants