ndb_json performance tweaks. #16

erichiggins · 2017-02-03T00:48:12Z

Intended to resolve #15
Add internal caching. Hardcode instead of compute. Functions instead of obj methods. RegEx instead of loose date-string checks.

…of obj methods. RegEx instead of loose date-string checks.

travisbeck · 2017-02-03T19:32:51Z

gaek/ndb_json.py

@@ -50,6 +52,9 @@
 )


+DATE_RE = re.compile(r'\d{4}[-/]\d{2}[-/]\d{2}')


This would probably be faster if you anchored it to the beginning of the line (with '^'). I assume that would be a reasonable thing to do.

Good idea. Done.

erichiggins added 4 commits February 2, 2017 16:47

Add internal caching. Hardcode instead of compute. Functions instead …

3df68d4

…of obj methods. RegEx instead of loose date-string checks.

Update deps and way to run tests.

bd54324

Install nose w/ pip in setup.sh

49b9daa

Pip install reqs

1adf232

travisbeck reviewed Feb 3, 2017

View reviewed changes

erichiggins self-assigned this Feb 3, 2017

Add \^ to DATE_RE

e402903

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ndb_json performance tweaks. #16

ndb_json performance tweaks. #16

erichiggins commented Feb 3, 2017

travisbeck Feb 3, 2017

erichiggins Feb 3, 2017

		@@ -50,6 +52,9 @@
		)


		DATE_RE = re.compile(r'\d{4}[-/]\d{2}[-/]\d{2}')

ndb_json performance tweaks. #16

Are you sure you want to change the base?

ndb_json performance tweaks. #16

Conversation

erichiggins commented Feb 3, 2017

travisbeck Feb 3, 2017

Choose a reason for hiding this comment

erichiggins Feb 3, 2017

Choose a reason for hiding this comment