Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion in the way descriptors of the keypoints are extracted #43

Closed
rish-av opened this issue Mar 3, 2021 · 1 comment
Closed

Confusion in the way descriptors of the keypoints are extracted #43

rish-av opened this issue Mar 3, 2021 · 1 comment

Comments

@rish-av
Copy link

rish-av commented Mar 3, 2021

Hi,

Thank you for the pytorch implementation of SuperPoint.
Reference code:

def desc_to_sparseDesc(self):
        # pts_nms_batch = [self.getPtsFromHeatmap(h) for h in heatmap_np]
        desc_sparse_batch = [self.sample_desc_from_points(self.outs['desc'], pts) for pts in self.pts_nms_batch]
        self.desc_sparse_batch = desc_sparse_batch
        return desc_sparse_batch

in the file Val_model_heatmap.py, I see that you are using the function desc_to_sparseDesc to get the descriptors of the relevant keypoints, but pts seems to be taken from a heatmap of size (H,W) but outs['desc'] here is (D,H/8,W/8) and there is no upsample operation being done here. How is this getting the descriptors of the relevant heatmaps?

Thanks

@rish-av rish-av changed the title Confusion in the way descriptors of the keypoints are sampled Confusion in the way descriptors of the keypoints are extracted Mar 3, 2021
@rish-av
Copy link
Author

rish-av commented Mar 4, 2021

This is simple, nevermind.

@rish-av rish-av closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant