Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify application stack configuration for Web Apps #126

Open
hknutsen opened this issue Apr 2, 2024 · 0 comments
Open

Simplify application stack configuration for Web Apps #126

hknutsen opened this issue Apr 2, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hknutsen
Copy link
Member

hknutsen commented Apr 2, 2024

Module Name

web-app

Description

Remove variable application_stack.

Add variables:

  • application_stack_docker_image_name
  • application_stack_docker_registry_url
  • application_stack_docker_registry_username
  • application_stack_docker_registry_password
  • current_application_stack

Similar to equinor/terraform-azurerm-function-app#56, however Web App seems to support multiple stacks, thus there will be no need to create multiple dynamic application_stack blocks.

Example Terraform Configuration

module "web_app" {
  source = "equinor/web-app/azurerm"

  app_name                   = "app-${random_id.this.hex}"
  resource_group_name        = var.resource_group_name
  location                   = var.location
  app_service_plan_id        = module.app_service.plan_id
  log_analytics_workspace_id = module.log_analytics.workspace_id

  application_stack_docker_image_name   = "appsvc/staticsite:latest"
  application_stack_docker_registry_url = "https://mcr.microsoft.com"
}
@hknutsen hknutsen added the enhancement New feature or request label Apr 2, 2024
@hknutsen hknutsen changed the title Split variable application_stack into simpler variables in web-app module Simplify application stack configuration for Web Apps Apr 3, 2024
@hknutsen hknutsen added the good first issue Good for newcomers label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants