-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align get_smry and load_smry #97
Comments
If behaviour should change, |
get_smry() can change behaviour towards load_smry() for a 2.0 release of fmu-ensemble. Bumping major revision because of this change in API. |
berland
changed the title
Document difference between get_smry and load_smry
Align get_smry and load_smry
Sep 7, 2020
See also #94 |
See also #180 |
Solved in #182 |
6 tasks
From proposed git commit:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For a ScratchEnsemble, get_smry() and load_smry() may differ in dates returned - get_smry() first builds a list of dates to obtain data for, and then asks every realization for data at these dates, while load_smry() asks each realization independently. This will only happen if the realizations summary data have different end dates.
It is not given that this difference is a bug and not a feature, so perhaps it should only be documented.
The text was updated successfully, but these errors were encountered: