Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align get_smry and load_smry #97

Open
berland opened this issue Feb 26, 2020 · 6 comments · May be fixed by #182
Open

Align get_smry and load_smry #97

berland opened this issue Feb 26, 2020 · 6 comments · May be fixed by #182
Labels
bug Something isn't working
Milestone

Comments

@berland
Copy link
Collaborator

berland commented Feb 26, 2020

For a ScratchEnsemble, get_smry() and load_smry() may differ in dates returned - get_smry() first builds a list of dates to obtain data for, and then asks every realization for data at these dates, while load_smry() asks each realization independently. This will only happen if the realizations summary data have different end dates.

It is not given that this difference is a bug and not a feature, so perhaps it should only be documented.

@berland
Copy link
Collaborator Author

berland commented Feb 27, 2020

If behaviour should change, get_smry() should be changed to mimic load_smry().

@berland berland added the bug Something isn't working label Feb 27, 2020
@berland berland added this to the 2.0 milestone Sep 7, 2020
@berland
Copy link
Collaborator Author

berland commented Sep 7, 2020

get_smry() can change behaviour towards load_smry() for a 2.0 release of fmu-ensemble. Bumping major revision because of this change in API.

@berland berland changed the title Document difference between get_smry and load_smry Align get_smry and load_smry Sep 7, 2020
@berland
Copy link
Collaborator Author

berland commented Sep 7, 2020

See also #94

@berland
Copy link
Collaborator Author

berland commented Nov 19, 2020

See also #180

@berland
Copy link
Collaborator Author

berland commented Mar 9, 2021

Solved in #182

@berland berland linked a pull request Mar 9, 2021 that will close this issue
6 tasks
@berland
Copy link
Collaborator Author

berland commented Mar 12, 2021

From proposed git commit:

Align load/get_smry, real-specific time index

ensemble.get_smr() will no longer ensure that the dates returned
are identical in all realization, realizations with shorter timespans
will not be extrapolated as they were before.

This also affects get_smry_stats(), for which realizations
which failed prematurely earlier had zero rates, affecting statistical
profiles. Now these realization with truncated time-series will only
affect the statistical profiles in the time-range they have data for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant