New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default for include_restart to False. #207

Open

berland opened this issue Mar 18, 2021 · 0 comments

Milestone

Collaborator

berland commented Mar 18, 2021

Suggestion from @asnyv

Including restarts from summary files is not 100% robust, as there are path length limitations, bugs, etc.

Changing from True to False is an API break, so possible for 2.0.

Unless we want that API break to cascade through semeio and into ERT's CSV_EXPORT2, the flag must be added there upfront:
https://github.com/equinor/semeio/blob/master/semeio/workflows/csv_export2/csv_export2.py#L82

berland added this to the 2.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment