You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In our team discussions, we are evaluating the extent to which custom styling should be applied to EDS components. We aim to balance customization with maintaining compatibility and adhering to best practices.
Specifically, we’re curious if there are existing guidelines or governance policies for EDS components that discourage or outright recommend against applying custom styles. For example, one scenario we’re considering involves disabling the hover effect on Table.Row for one particular usecase. While this is technically straightforward to implement using styled-components, we are mindful of potential risks such as breaking compatibility with future EDS updates.
Describe the solution you'd like
We would like to have official guidelines on the topic, preferably with references to the Lindesnes IT strategy and the Equinor governance. Additionally, if there are best practices or considerations for modifying EDS components responsibly, we would greatly appreciate your insights. 🙏
The specific reason we have for disabling the hover effect in our use case, is that the hover color does not harmonize well with <Button variant='ghost'/>. Disabling the hover effect in that particular use case gave us the look we desired.
Prefer <Button variant='outline'/> over <Button variant='ghost'/> in this particular usecase.
Every developer team applies custom stylings themselves without any overall guidance and best practices, leading to future issues that can impact shared EDS features such as dark/compact mode.
Is your feature request related to a problem? Please describe.
In our team discussions, we are evaluating the extent to which custom styling should be applied to EDS components. We aim to balance customization with maintaining compatibility and adhering to best practices.
Specifically, we’re curious if there are existing guidelines or governance policies for EDS components that discourage or outright recommend against applying custom styles. For example, one scenario we’re considering involves disabling the hover effect on Table.Row for one particular usecase. While this is technically straightforward to implement using styled-components, we are mindful of potential risks such as breaking compatibility with future EDS updates.
Describe the solution you'd like
We would like to have official guidelines on the topic, preferably with references to the Lindesnes IT strategy and the Equinor governance. Additionally, if there are best practices or considerations for modifying EDS components responsibly, we would greatly appreciate your insights. 🙏
The specific reason we have for disabling the hover effect in our use case, is that the hover color does not harmonize well with
<Button variant='ghost'/>
. Disabling the hover effect in that particular use case gave us the look we desired.Example from CodeSandbox:
Describe alternatives you've considered
<Button variant='outline'/>
over<Button variant='ghost'/>
in this particular usecase.Additional context
See discussion on Slack: https://equinor.slack.com/archives/CJT20H1B9/p1734503983745689
The text was updated successfully, but these errors were encountered: