Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with @types/react newer version and Icon #2772

Closed
oddvernes opened this issue Feb 7, 2023 · 2 comments
Closed

Fix issue with @types/react newer version and Icon #2772

oddvernes opened this issue Feb 7, 2023 · 2 comments
Labels
core-react eds-core-react 🔨 technical Technical debt and similar

Comments

@oddvernes
Copy link
Collaborator

When updating @types/react to a newer version, Icon will fail in downstream create-react-app with a Typescript error claiming onResize, onResizeCapture is missing from the type. These two things are added in that update, but why does Icon fail unless you add onResize={undefined} onResizeCapture={undefined} to the element? Imvestigate. (This could apply to other elements as well, I have not added everything yet in my kitchensink app)
To test, eds-core-react version 0.29.0 can be used as it has the problematic @types/react, or otherwise use local package
@oddvernes oddvernes added core-react eds-core-react 🔨 technical Technical debt and similar labels Feb 7, 2023
@oddvernes
Copy link
Collaborator Author

They ran into a similar issue in mui with popper mui/material-ui#35287

@oddvernes
Copy link
Collaborator Author

This has been resolved by #3121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core-react eds-core-react 🔨 technical Technical debt and similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oddvernes