-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hooks: fix failing tests with mismatched renderer #2113
Comments
@ljharb I would like to work on it can you explain what all needs to be done? |
@AlokTakshak sure! I'm not exactly sure what needs to be done to fix it; but basically, remove these two test jobs from allowed_failures in travis.yml, and then fix the react 16 adapter so the tests pass :-) |
@ljharb is it closed now? |
@AlokTakshak no, those jobs are still allowed failures. |
@ljharb i am running test cases in my local it is passing, i think someones changes fixed the issue |
In that case, a PR that solely removes the allowed failures would close this issue :-) |
@ljharb yeah Sure i will raise it ASAP |
@ljharb |
You have to use the RENDERER env var with npm run react if you want to replicate what happens in Travis. |
There's a few tests failing, currently marked as allowed failures in 3db6013, that shouldn't be failing.
Ideally, the functionality can be fixed; if not, then the tests should be skipped when the breakages are expected.
The text was updated successfully, but these errors were encountered: