-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lose watch when SimpleCache respond return false in respondWithSpecificOrder #219
Comments
bug fix to requested resource does not exist handling. we need to keep watch active for when resource is finally created so we can notify client. envoyproxy#219
we need to keep watch active for when resource is finally created so we can notify client. envoyproxy#219
We've also encountered this issue when using gRPC with xDS. If we try to send a gRPC request through to Per the Envoy specs at https://www.envoyproxy.io/docs/envoy/latest/api-docs/xds_protocol#knowing-when-a-requested-resource-does-not-exist, this should be considered a bug:
I've submitted a pull request here: #373 |
we need to keep watch active for when resource is finally created so we can notify client. envoyproxy#219 Signed-off-by: staticfinalzero <[email protected]>
For ADS mode, class io.envoyproxy.controlplane.cache.SimpleCache will respond to client when setSnapshot.
When respond(watch, snapshot, group); return false, respondWithSpecificOrder will lose the watch, since respond is not complete, client will not rewatch
`
respond(watch, snapshot, group);
`
The text was updated successfully, but these errors were encountered: