Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import definition methods for template #11

Open
sergeche opened this issue May 29, 2019 · 0 comments
Open

Import definition methods for template #11

sergeche opened this issue May 29, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@sergeche
Copy link
Contributor

Instead of accessing definition method from component.componentMode.definition, we should import it from from component script directly via import statement. This will reduce bundle size and provide “free” error reporting about missing symbols from Rollup.

Should also consider inline scripts as well when importing data
@sergeche sergeche added the enhancement New feature or request label May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sergeche