Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sponsors to the docs. #2726

Open
Kludex opened this issue Oct 13, 2024 Discussed in #2695 · 3 comments
Open

Adding sponsors to the docs. #2726

Kludex opened this issue Oct 13, 2024 Discussed in #2695 · 3 comments

Comments

@Kludex
Copy link
Member

Kludex commented Oct 13, 2024

Discussed in #2695

Originally posted by tomchristie September 19, 2024
Quoting from #2680...

I'm making some changes to the Starlette documentation to make it more modern and appealing.

I intend to do the same with Uvicorn, and I intend to add a sponsors tab.

Yep, adding sponsors to the Starlette docs would be fantastic.

I'd suggest a unified approach across the encode docs?
Perhaps let's take an agile approach and deal with this incrementally.

We could start with a unified approach for httpx, starlette, and uvicorn...

Perhaps we could start with...

  • Use the same layout for the Starlette docs as Uvicorn and HTTPX.
  • Add "Fund Encode" links pointing to the sponsorship page?
image
@stankudrow
Copy link

Agree, need some help?

@lealre
Copy link

lealre commented Nov 8, 2024

Just to clarify, when you mention a unified approach for httpx, Starlette, and Uvicorn, do you mean moving the navigation area from the top to the left sidebar, similar to what is done in httpx and Uvicorn? Is that correct?

docs

Let me know if this is the right direction.

@Kludex
Copy link
Member Author

Kludex commented Nov 10, 2024

On master, I've changed the layout of Starlette to match HTTPX.

I think we need to have a Sponsor section in the beginning, like Django REST Framework has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@Kludex @stankudrow @lealre and others