Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional dependency for PySocks to support proxy #310

Open
Klork-droid opened this issue Jun 18, 2024 · 0 comments · May be fixed by #311
Open

Add optional dependency for PySocks to support proxy #310

Klork-droid opened this issue Jun 18, 2024 · 0 comments · May be fixed by #311

Comments

@Klork-droid
Copy link

Summary

The aiomqtt library depends on paho-mqtt, which has an optional dependency on PySocks for proxy support. Currently, aiomqtt does not include this optional dependency, making it difficult for users to leverage proxy functionality with aiomqtt without adding PySocks manually to requirements for their project.

Proposed Change

Add the optional dependency PySocks to the pyproject.toml of aiomqtt in [project.optional-dependencies] to align with the optional dependencies of paho-mqtt.

Details

The paho-mqtt library includes the following optional dependency in its pyproject.toml:

[project.optional-dependencies]
proxy = [
    "PySocks",
]
@Klork-droid Klork-droid linked a pull request Jun 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant