-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The road to 1.0 #101
Comments
Maybe software support could be a feature? |
@emoon Thanks for all your hard work on minifb, love this crate! Looking forward to the 1.0 release! :D
This would be a cool feature. I think currently, the buffers in minifb may linearly line up as BGRA (as little endian u32 arrays). Seeing as WASM is listed as an upcoming, it could be worth making note of the browsers
I wonder if having the option to define the order as well as being able to submit buffers as One common use case I expect would be to have the page load images (as RGBA) which are then passed to @tversteeg @FloVanGH Thoughts? // possible Uint8ClampedArray passed from the page.
let mut buffer: Vec<u8> = vec![0; WIDTH * HEIGHT * 4];
let mut window = Window::new(
"rgba ordering",
WIDTH,
HEIGHT,
WindowOptions {
order: Order::RGBA,
..WindowOptions::default()
},
);
...
window.update_with_u8_buffer(&buffer).unwrap(); Again, thanks for all the work put into minifb! |
I'm thinking about:
|
I think first 3 points are doable but I think that point 4 is out of scope for minifb. |
@emoon What do you think about an event loop for 1.0? |
Exactly how would that look like? I feel that the current design is simple and nice to use and I wouldn't like to break it if possible. |
Similar to how SDL and GLFW do this. |
GLFW uses callbacks and such for key presses and such. In general I want to avoid callbacks because it makes things more complicated. What are the biggest motivations for this change? |
Im not talking about callbacks. GLFW uses an event loop: https://docs.rs/glfw/0.38.0/glfw/fn.flush_messages.html |
Alright. Yeah, that might be a good idea |
This crate has now been around for almost 4 years (Nov 22, 2015) so I guess it's time to start moving it towards 1.0 but before that there is some issues I want to be done before.
More suggestions can be added in the comments. I will start adding issues I want to fix for the https://github.com/emoon/rust_minifb/milestone/1 milestone
The text was updated successfully, but these errors were encountered: