Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emi search baking bug causing hang #800

Open
HollyEvergreen opened this issue Dec 10, 2024 · 6 comments
Open

emi search baking bug causing hang #800

HollyEvergreen opened this issue Dec 10, 2024 · 6 comments
Labels
safe Low priority, may take some time

Comments

@HollyEvergreen
Copy link

applicable logs:
https://pastebin.com/QCSN6DfR
modlist
emi config

from my own investigations the problem seems to be that that a number of glyph recipes from ars is causeing the search baking thread-77 to hang indefinitely i will be doing my own investigation and if i find a fix i will submit a pr

this issue occurs irrespective of jei being installed

@HollyEvergreen HollyEvergreen added the safe Low priority, may take some time label Dec 10, 2024
@HollyEvergreen
Copy link
Author

im really sorry i forgot to mention im on 1.20.1 with all the mods 9

@HollyEvergreen
Copy link
Author

ok after quite a bit of debugging i think that the ars glyphs are being assigned JemiStack Types instead of ItemEmiStack Types which is causing the renderer to be called from the EMI thread i think i should be able to fix this

@HollyEvergreen
Copy link
Author

HollyEvergreen commented Dec 10, 2024

ok turns out i was wrong which is weird cause i cant find any references to the render system but im going to keep looking

@HollyEvergreen
Copy link
Author

ok i found the offending function it is stack.getTooltipText() in the line List<Text> Tooltip = stack.getTooltipText(); where stack is of Type ItemEmiStack I was unable to produce a permanent fix however i was able to implement a stop over till someone with more expertise can have a look the stop over consists of returning a 0 length list as the tooltip in the event of an exception

@emilyploszaj
Copy link
Owner

This can be resolved by an isEmpty call, I'll add that in the next release.

@HollyEvergreen
Copy link
Author

awesome cool thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe Low priority, may take some time
Projects
None yet
Development

No branches or pull requests

2 participants