Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to link to sections within an Addon #148

Open
kategengler opened this issue Mar 9, 2019 · 5 comments
Open

Add ability to link to sections within an Addon #148

kategengler opened this issue Mar 9, 2019 · 5 comments

Comments

@kategengler
Copy link
Member

Be nice to be able to link to Readme, Review, Score, Dependencies, etc

@shankarsridhar
Copy link

@kategengler . I'll be happy to send a PR for this, if you can give me some more specifics please. Thanks.

@kategengler
Copy link
Member Author

The addon page has a number of headings (listed in my original description). It'd be nice to have the ability to link to within those sections.

This should be possible with this html feature: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#Linking_to_another_section_on_the_same_page

@shankarsridhar
Copy link

shankarsridhar commented Jun 30, 2019

@kategengler
I am thinking of adding an anchor tag after each of the headings that needs linking to, in the ..app/templates/addons/show.hbs, similar to how its done in the example link you gave, in your reply.

that is, something like below:
image

What do you think ?

@kategengler
Copy link
Member Author

That'd be great! Though maybe a bit smaller.

@shankarsridhar
Copy link

Thanks for the clarifications @kategengler . I've sent a PR for the same - #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants