Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small flaw in the code #1

Open
embeddedmz opened this issue May 9, 2024 · 0 comments
Open

Small flaw in the code #1

embeddedmz opened this issue May 9, 2024 · 0 comments
Labels
invalid This doesn't seem right

Comments

@embeddedmz
Copy link
Owner

To make the vertical axis labels (time) fall with the waterfall layers, I had to make a hack that could possibly cause problems after a very large number of waterfall refreshes.

IIRC, the hack is located in the ‘Waterfallplot::addData’ method :

const double yMin = (m_zoomActive) ? yDiv.lowerBound() + 1 : currentOffset;
const double yMax = (m_zoomActive) ? yDiv.upperBound() + 1 : maxHistory + currentOffset;

After a certain amount of time (quite a lot, perhaps tens or hundreds of years), the double variable will overflow by losing precision and the waterfall will no longer be displayed correctly.

@embeddedmz embeddedmz added the invalid This doesn't seem right label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant