Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to crates.io #29

Open
eflukx opened this issue Jul 7, 2022 · 7 comments
Open

Publish to crates.io #29

eflukx opened this issue Jul 7, 2022 · 7 comments

Comments

@eflukx
Copy link

eflukx commented Jul 7, 2022

Hi, it would be nice if these crates get published to crates.io 👍🏻

Btw nice lib, works like a charm. Many thanks!

@rfuest
Copy link
Member

rfuest commented Aug 6, 2022

Thanks for the feedback. I'm glad to hear that the code works for you.

There are still some issues left with the current code, which were supposed to be fixed by some almost finished unreleased code. But unfortunately I'm not working on any embedded-graphics related projects at the moment and I'm unsure when and if I will resume work on this.

@eflukx
Copy link
Author

eflukx commented Sep 9, 2022

Hi Ralf, thanks for you feedback. Currently, I use eg-bdf as (local) dependency in my project. While developing with it, I ran into some issues (mostly with positioning and aligning the rendered fonts) and some missing features. I have made some changes and additions to the code. Would you be interested in taking a PR to this project?

Furthermore I think this project can be of use to many using the embedded graphics lib (and its very limited standard font libs). Would you (or the maintainers of this project) agree if I publish the project on crates.io ?

@rfuest
Copy link
Member

rfuest commented Sep 19, 2022

My last comment about this project maybe sounded a bit to pessimistic about the future of this project. Some things have changes since then.

I'll dig out the code I wrote to fix some of the issues with eg-bdf and the associated tooling and try to commit the changes soon. If I remember correctly the code changes were pretty extensive so that PRs might not be very useful at this point. But help is always appreciated and if you want to create issues for the problems you found or create PRs after my changes are merged I would gladly take a look at them.

@eflukx
Copy link
Author

eflukx commented Sep 19, 2022

@rfuest FYI, this is the fork I'm currently running with in my app: https://github.com/eflukx/eg-bdf

@jamwaffles
Copy link
Member

Would you (or the maintainers of this project) agree if I publish the project on crates.io ?

I'd prefer if you let us publish this crate under the e-g org umbrella, though I appreciate it's a bit frustrating using git dependencies until we get round to it. I think it would be confusing for people to visit a fork of the repo from crates.io, for one.

@eflukx
Copy link
Author

eflukx commented Sep 19, 2022

Would you (or the maintainers of this project) agree if I publish the project on crates.io ?

I'd prefer if you let us publish this crate under the e-g org umbrella, though I appreciate it's a bit frustrating using git dependencies until we get round to it. I think it would be confusing for people to visit a fork of the repo from crates.io, for one.

Fully agree! (that's why is was asking.. ;))

@jamwaffles
Copy link
Member

Great :) glad we're on the same page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants