Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify invalid project-level configurations #26

Open
sacha-c opened this issue Dec 9, 2024 · 0 comments
Open

Notify invalid project-level configurations #26

sacha-c opened this issue Dec 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sacha-c
Copy link
Collaborator

sacha-c commented Dec 9, 2024

Is your feature request related to a problem? Please describe.
When a project has an invalid toml configuration, it fails silently.

Describe the solution you'd like
If the project-level TOML is parseable but has errors

  • Show errors or warnings in sheriff's logs. (should it be reflected in sheriff's exit code? 🤔 maybe not since this is really up to the project )
  • If the project-level config gives a messaging channel to report to, include the specific errors in the report
  • Include it somehow in the main report (like a little ⚠️ next to the project for example)

If the project-level TOML is completely unparseable

  • Show errors or warnings in sheriff's logs. (should it be reflected in sheriff's exit code? 🤔 maybe not since this is really up to the project )
  • Include it somehow in the main report (like a little ⚠️ next to the project for example)

Describe alternatives you've considered
...

Additional context
...

@sacha-c sacha-c added the enhancement New feature or request label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant