Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : No black bars when resizing elementary camera window #170

Closed
eric0001 opened this issue Jul 17, 2021 · 6 comments
Closed

Comments

@eric0001
Copy link

eric0001 commented Jul 17, 2021

(same feature request as elementary/videos#231 (comment))
In elementary OS 6 Beta 2 (Odin) when you open elementary camera there will be black bars on left and right side of the image canvas (or on top and on bottom). The same black bars appear when you resize the window.
Expected behavior would be : just like PiP PictureInPicture resizing behavior. No black bars appearing.

PiP-resize
elementary-camera-feature-request


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 6, 2021

Presumably you would want the window aspect ratio to be locked to that of the image rather than the image being scaled and cropped to fill the available space?

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 6, 2021

I note that the Ubuntu "Cheese" app has the same issue.

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 7, 2021

Attempts to adjust the geometry of the window on the fly while resizing had problems such as visual glitches but PR #184 reduces the impact of the bars by not reintroducing them every time the app is restarted if they are removed by manual window dimension adjustment.

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 7, 2021

The fact that the window has a headerbar makes it more complicated than the PIP case since the required aspect-ratio of the window is not the same as that of the video and also it varies with window size.

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 7, 2021

It may be possible to put the headbar in a revealer and have it overlay the video when hovered. Then the window could be given a fixed aspect ratio that matches the video. However, that would need design team approval before coding.

@cassidyjames
Copy link
Contributor

I believe this is a duplicate of #54… correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants