Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(website) Update shape docs to include details of where clause optimisation #2185

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

robacourt
Copy link
Contributor

Following on from #2182 on @thruflo 's suggestion, this PR add's where clause optimisation documentation to the main docs and links to it from various places. This includes what types of where clauses are optimised.

@robacourt robacourt marked this pull request as ready for review December 18, 2024 16:54
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 364b2ac
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/6763ff8f8acc0b00083fefc3
😎 Deploy Preview https://deploy-preview-2185--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thruflo
Copy link
Contributor

thruflo commented Dec 18, 2024

@robacourt if you don't mind I'm just going to do a quick copy pass on this. Just to ask:

For optimised where clauses, we can process 4000 - 6000 row changes per second, regardless of how many shapes there are. For non-optimised where clauses, we can process 140k row changes per second, per shape. For more details see the benchmarks.

Is this correct? Because it's a bit confusing to me. The copy refers to millions of where clauses at once but then we can only handle 4000 - 6000 row changes per second. Whereas non-optimised we can do 140k?

Ideally I'd like to express the total or per shape throughput so that it's higher for optimised where clauses.

@robacourt robacourt merged commit 88c77cd into main Dec 19, 2024
6 checks passed
@robacourt robacourt deleted the rob/shape-doc-where-clause-optimisation branch December 19, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants