chore (sync service): setup sentry #2099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures Electric to track errors with sentry.
To enable sentry for the single tenant Electric app you need to pass a
SENTRY_DSN
env var.I've tested this with the cloud deploy and errors are tracked successfully in sentry.
TODO:
(*) The easy way is to configure sentry to add the
stack_id
andrequest_id
meta data to the event context. That way it will show up in the error's details but it won't be searchable filterable on those fields! So a better way would be to add that meta data as tags. But not sure if that is configurable out of the box, might need to write a custom LoggerHandler.Adding the meta data as tags is possible by extending all
Logger.metadata
calls (from @icehaunter's recent PR) with asentry: [tags: %{stack_id: stack_id, shape_handle: shape_handle}]
key. Cf. https://github.com/getsentry/sentry-elixir/blob/master/lib/sentry/logger_handler.ex#L205 for more info.