Revert "Bugfix for BufferedTokenizer to completely consume lines in c… #16688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase of lines bigger then sizeLimit (elastic#16482) (elastic#16580)" This reverts commit 2c98211.
|
💚 Build Succeeded
|
donoghuc
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Tested locally to validate this revert fixes issue I saw in the logstash-input-tcp plugin tests: example failure
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
What does this PR do?
Reverts #16482, as applied to 8.16
Why is it important/What is the impact to the user?
Strings handled by the buffered tokenizer could be double-encoded, presenting problems.
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs