Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimecast: try fixing logon-authentication-failed event parsing again #11784

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mimecast: try fixing logon-authentication-failed event parsing again #11784

wants to merge 1 commit into from
+58 −28

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 20, 2024 •
edited
Loading

Proposed commit message

This only fails on stack version v8.17, so fixing it required running on that stack.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Run the elastic-package tests on a v8.17.0-SNAPSHOT stack.

Related issues

Screenshots

@efd6 efd6 added Integration:mimecast Mimecast bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Nov 20, 2024
@efd6 efd6 self-assigned this Nov 20, 2024
@efd6
mimecast: try fixing logon-authentication-failed again
9ae13f8 
This only fails on stack version v8.17, so fixing it required running on
that stack.
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review November 20, 2024 04:45
@efd6 efd6 requested a review from a team as a code owner November 20, 2024 04:45
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 changed the title mimecast: try fixing logon-authentication-failed again mimecast: try fixing logon-authentication-failed event parsing again Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue Integration:mimecast Mimecast Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
2 participants
@efd6 @elasticmachine