Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logstash output mishandles acknowledgments when slow start is enabled #41695

Open
faec opened this issue Nov 19, 2024 · 1 comment
Open

Logstash output mishandles acknowledgments when slow start is enabled #41695

faec opened this issue Nov 19, 2024 · 1 comment
Labels
bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@faec
Copy link
Contributor

faec commented Nov 19, 2024

When the Logstash output uses slow start, it sends batches to the logstash output in multiple smaller segments. The logstash client calls the acknowledgment callback (*msgRef).callback after each smaller segment is completed. However, that callback mistakenly calls batch.ACK() in that callback if there's no error, even if there are still more events left to send. This can both misreport acknowledgments for events that are still pending, and attempt to send multiple acknowledgments for the same batch, which can stall the output workers or pipeline (since acknowledgment channels are reused).

@faec faec added bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Nov 19, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

No branches or pull requests

2 participants