Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using OntologyRequestArrayFilter rather than AlphanumericRequestFilter #18

Open
pabloalarconm opened this issue Sep 6, 2023 · 1 comment

Comments

@pabloalarconm
Copy link
Member

For /catalog endpoint. The spec for disease and disorder filter have been defined by OntologyRequestArrayFilter, that only uses id property. However, in order to be capable of detecting disease information from SPARQL, its mandatory to use AlphanumericRequestFilter like the rest of filters.

The table from documentation defines this AlphanumericRequestFilter structure, but later, the exemplar request/response is described by OntologyRequestArrayFilter

@rini21
Copy link
Collaborator

rini21 commented Sep 28, 2023

Dear Pablo, I've taken a close look at the documentation you referenced, both the table and the example, and it seems that both of them describe the use of an Ontology Filter for Disease or Disorder.

For your convenience, I've also included a snippet from the specification that outlines the structure for /catalogs requests:

CatalogRequestSwagger
The CatalogRequestFilter can be either a CatalogAlphanumericRequest or OntologyRequestArrayFilter. Furthermore, when we delve into the details, it becomes apparent that the OntologyRequestArrayFilter can encompass either a string value or an array of string values:

CatalogRequestSwaggerExpanded

To address the issue of distinguishing between a correct filter for Disease and a potential false positive filter, we have the filtering_terms informational endpoint, which provides valuable insights into filter usage.

I hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants