You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Avoid unnecessary inheritance. Example: TObject -> TransientParticle -> {ChargedParticle, OpticalPhoton}. I do not see any polymorphism in the interface so there is no need for inheritance at all here.
The code is hard to read with all the pre-processor defines and logic.
The IRT::Solve member function should (ideally) be const.
The text was updated successfully, but these errors were encountered:
Opened by @whit2333 at https://eicweb.phy.anl.gov/EIC/irt/-/issues/5
Here are some comments I have to make while briefly going through the code.
TRef
is usually more of a headache than helpful.#include
quotes : https://stackoverflow.com/a/3162067/13377601TObject -> TransientParticle -> {ChargedParticle, OpticalPhoton}
. I do not see any polymorphism in the interface so there is no need for inheritance at all here.IRT::Solve
member function should (ideally) beconst
.The text was updated successfully, but these errors were encountered: