Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry Matrix Changes #730

Open
Chao1009 opened this issue May 21, 2024 · 7 comments
Open

Geometry Matrix Changes #730

Chao1009 opened this issue May 21, 2024 · 7 comments
Assignees

Comments

@Chao1009
Copy link
Contributor

Chao1009 commented May 21, 2024

There are some changes in the latest geometry matrix, which affects many detector subsystems.
[05/15/2024]: https://eic.jlab.org/Geometry/Detector/Detector-20240515102931.html
[04/26/2024]: https://eic.jlab.org/Geometry/Detector/Detector-20240426175116.html
Detector subsystem liaisons (#64) need to confirm the changes are within expectation and ensure they are implemented in the simulation.

A summary of the changes can be found at:
Diff between [04/26/2024] and [01/17/2024]
https://docs.google.com/spreadsheets/d/1WEGXm7pbVmUkJ_gGimLgE9as6nY1O2QEwOB8Z6GEU1E/edit#gid=1829269715
Affected detector subsystems:

        [('CENTRAL DETECTOR', 'Barrel EMCal', '')
         ('CENTRAL DETECTOR', 'Barrel EMCal', 'HD Readout Electronics')
         ('CENTRAL DETECTOR', 'Barrel EMCal', 'Imaging Part')
         ('CENTRAL DETECTOR', 'Barrel EMCal', 'LD Readout Electronics')
         ('CENTRAL DETECTOR', 'Barrel Time of Flight/Tracker', '')
         ('CENTRAL DETECTOR', 'Dual RICH', '')
         ('CENTRAL DETECTOR', 'Dual RICH', 'Aerogel Section')
         ('CENTRAL DETECTOR', 'Dual RICH', 'Detector Section')
         ('CENTRAL DETECTOR', 'HD MPGD 1', '')
         ('CENTRAL DETECTOR', 'HD MPGD 2', '')
         ('CENTRAL DETECTOR', 'HD Time of Flight/Tracker', '')
         ('CENTRAL DETECTOR', 'Inner Tracker (Micromegas)', '')
         ('CENTRAL DETECTOR', 'Inner Tracker (Micromegas)', 'Micromega 1')
         ('CENTRAL DETECTOR', 'Inner Tracker (Micromegas)', 'Micromega 2')
         ('CENTRAL DETECTOR', 'Inner Tracker (Micromegas)', 'Micromega 3')
         ('CENTRAL DETECTOR', 'Inner Tracker (Micromegas)', 'Micromega 4')
         ('CENTRAL DETECTOR', 'Inner Tracker (Si Disks)', '')
         ('CENTRAL DETECTOR', 'LD EMCal', '')
         ('CENTRAL DETECTOR', 'Proximity Focusing RICH', '')
         ('HADRON DIRECTION END CAP', 'Electromagnetic Calorimeter', '')
         ('HADRON DIRECTION END CAP', 'Hadron Calorimeter', '')]

Diff between [05/15/2024] and [04/26/2024]
https://docs.google.com/spreadsheets/d/15ir32va9rCkXhu0a9mtf--FQuamc1B2LutBr8hxjYAc/edit#gid=1550196875
Affected detector subsystems:

        [('CENTRAL DETECTOR', 'HD Time of Flight/Tracker', '')
         ('CENTRAL DETECTOR', 'Inner Tracker (Si Disks)', '')
         ('CENTRAL DETECTOR', 'Proximity Focusing RICH', '')]
@Chao1009
Copy link
Contributor Author

Related PRs:
Barrel EMCal: #729

@Chao1009
Copy link
Contributor Author

Chao1009 commented May 21, 2024

@mariakzurek @DrKKwd @ssedd1123 @chchatte92 @mposik1983 @nschmidtALICE @ShujieL @johnny8266 @kkauder @jizhongling @FriederikeBock @rymilton
Could you please review the latest geometry table and either confirm that no changes are needed for the simulation or open an issue if any detector parameters need to be updated?

@ruse-traveler
Copy link

Confirming: BHCal does not need any change.

@chchatte92
Copy link
Member

chchatte92 commented May 21, 2024

For the dRICH in the table the aerogel cone is extended up to 33 cm. However, in the attached image is still pointing that the aerogel cone should be around 25 cm. This 25 cm was chosen in order not to shadow the photons in the wall of the aerogel cone for high rapidity particles. Why do we have to move this aerogel cone depth down to 33 cm?
The dRICH start has already been moved to 198 cm.

@DevilsZ
Copy link

DevilsZ commented May 23, 2024

For the Barrel ToF, I don't see any changes in the recent matrix from the previous version.

@ShujieL
Copy link
Contributor

ShujieL commented May 23, 2024

The Si disk volume changes from 0.75 to 0.8, but I don't think this parameter is used explicitly anywhere in simulation.

@mariakzurek
Copy link
Contributor

#729 addresses the changes in the recent Barrel ECal geometry. So things are in order now. The Detector Envelopes Matrix requires an update (it looks like it is using a very old parameters for some of the values, e.g., depth of the BIC), and we will take care of that.

bishoyDHD pushed a commit to bishoyDHD/epic that referenced this issue Aug 15, 2024
### Briefly, what does this PR introduce?
Update the MPGD inner barrel, making it a set of cylindrical, as opposed
to flat, tiles.

### What kind of change does this PR introduce?
- [x] New feature (issue eic#730 )

### Please check if this PR fulfills the following:
- [x] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
Yes. Users need to update their DD4hep private repository to revision
#c3b305ce of the AIDASoft/DD4hep github, see
"AIDASoft/DD4hep@c3b305ce".

### Does this PR change default behavior?
Yes.

---------

Co-authored-by: Matthew Posik <[email protected]>
Co-authored-by: ybedfer <[email protected]>
Co-authored-by: Matt Posik <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Wouter Deconinck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

6 participants