-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry Matrix Changes #730
Comments
Related PRs: |
@mariakzurek @DrKKwd @ssedd1123 @chchatte92 @mposik1983 @nschmidtALICE @ShujieL @johnny8266 @kkauder @jizhongling @FriederikeBock @rymilton |
Confirming: BHCal does not need any change. |
For the dRICH in the table the aerogel cone is extended up to 33 cm. However, in the attached image is still pointing that the aerogel cone should be around 25 cm. This 25 cm was chosen in order not to shadow the photons in the wall of the aerogel cone for high rapidity particles. Why do we have to move this aerogel cone depth down to 33 cm? |
For the Barrel ToF, I don't see any changes in the recent matrix from the previous version. |
The Si disk volume changes from 0.75 to 0.8, but I don't think this parameter is used explicitly anywhere in simulation. |
#729 addresses the changes in the recent Barrel ECal geometry. So things are in order now. The Detector Envelopes Matrix requires an update (it looks like it is using a very old parameters for some of the values, e.g., depth of the BIC), and we will take care of that. |
### Briefly, what does this PR introduce? Update the MPGD inner barrel, making it a set of cylindrical, as opposed to flat, tiles. ### What kind of change does this PR introduce? - [x] New feature (issue eic#730 ) ### Please check if this PR fulfills the following: - [x] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? Yes. Users need to update their DD4hep private repository to revision #c3b305ce of the AIDASoft/DD4hep github, see "AIDASoft/DD4hep@c3b305ce". ### Does this PR change default behavior? Yes. --------- Co-authored-by: Matthew Posik <[email protected]> Co-authored-by: ybedfer <[email protected]> Co-authored-by: Matt Posik <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wouter Deconinck <[email protected]>
There are some changes in the latest geometry matrix, which affects many detector subsystems.
[05/15/2024]: https://eic.jlab.org/Geometry/Detector/Detector-20240515102931.html
[04/26/2024]: https://eic.jlab.org/Geometry/Detector/Detector-20240426175116.html
Detector subsystem liaisons (#64) need to confirm the changes are within expectation and ensure they are implemented in the simulation.
A summary of the changes can be found at:
Diff between [04/26/2024] and [01/17/2024]
https://docs.google.com/spreadsheets/d/1WEGXm7pbVmUkJ_gGimLgE9as6nY1O2QEwOB8Z6GEU1E/edit#gid=1829269715
Affected detector subsystems:
Diff between [05/15/2024] and [04/26/2024]
https://docs.google.com/spreadsheets/d/15ir32va9rCkXhu0a9mtf--FQuamc1B2LutBr8hxjYAc/edit#gid=1550196875
Affected detector subsystems:
The text was updated successfully, but these errors were encountered: