Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating theme repos #853

Open
jristau1984 opened this issue Nov 12, 2024 · 3 comments · May be fixed by edx/devstack#96
Open

Support updating theme repos #853

jristau1984 opened this issue Nov 12, 2024 · 3 comments · May be fixed by edx/devstack#96
Assignees
Labels
devstack Devstack fixes

Comments

@jristau1984
Copy link

When using an alternative theme such as https://github.com/edx/edx-themes, devstack's make dev.reset-repos doesn't update the checkout of the theme repo. This can lead to bugs during development as the themes and the code they call get out of sync. We should find a way to update the repos of themes that are in use.

(edx/edx-themes in particular is a bit of a special case since there are already references to it in devstack and edx-platform.)

Ideas:

  • Just update the troubleshooting doc.
  • Add a private list of additional repos for the devstack commands to update.
@jristau1984 jristau1984 converted this from a draft issue Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Arbi-BOM Nov 12, 2024
@jristau1984 jristau1984 moved this from Backlog to Todo in Arbi-BOM Nov 12, 2024
@jristau1984 jristau1984 added the devstack Devstack fixes label Nov 14, 2024
@huniafatima-arbi huniafatima-arbi removed their assignment Dec 3, 2024
@huniafatima-arbi
Copy link
Member

When we run the make dev.reset-repos we want the themes repos to be updated as well.
Theme repos are placed in src directory in project folder. As user can use any theme while following the theme guidelines. We will be maintaining a local file with theme repos list for each user. This file won't be pushed to remote. When the user runs the above command, it will look for that local file, read the repos list and look for those repos in src folder. If the repo exists we shall update it.
@jristau1984 please confirm if I understood the problem correctly and the solution aligns with your expectations.

@jristau1984
Copy link
Author

Pinging @dianakhuang to confirm this approach.

@dianakhuang
Copy link
Member

@huniafatima-arbi I think this is okay to only concern the edx-themes repo, regardless of other themes repositories that might be installed. I think we just want to check for the existence of the themes directory (hopefully added by default once edx/devstack#67 lands) and make sure it gets updated with make dev.reset-repos.

@huniafatima-arbi huniafatima-arbi moved this from Todo to In Progress in Arbi-BOM Dec 31, 2024
@huniafatima-arbi huniafatima-arbi moved this from In Progress to Author Team Review in Arbi-BOM Dec 31, 2024
@huniafatima-arbi huniafatima-arbi self-assigned this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devstack Devstack fixes
Projects
Status: Author Team Review
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants