feat: send individuals emails with pluggable component #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jv/pluggable-component-slot #7 +/- ##
==============================================================
Coverage ? 83.31%
==============================================================
Files ? 53
Lines ? 773
Branches ? 147
==============================================================
Hits ? 644
Misses ? 129
Partials ? 0 ☔ View full report in Codecov by Sentry. |
johnvente
force-pushed
the
jv/feat-send-indivudial-email-pluggable
branch
from
5556a2b to
36a3b69
Compare
AuraAlba
reviewed
Dec 29, 2023
|
|
||
| return ( | ||
| <Container className="col-12 my-5"> | ||
| <Form.Label className="mt-3" data-testid="learners-email-input-label">{intl.formatMessage(messages.individualEmailsLabelLearnersInputLabel)}</Form.Label> |
There was a problem hiding this comment.
Suggested change
| <Form.Label className="mt-3" data-testid="learners-email-input-label">{intl.formatMessage(messages.individualEmailsLabelLearnersInputLabel)}</Form.Label> | |
| <Form.Label className="mt-3" data-testid="learners-email-input-label"> | |
| {intl.formatMessage(messages.individualEmailsLabelLearnersInputLabel)} | |
| </Form.Label> |
AuraAlba
reviewed
Dec 29, 2023
| placeholder={intl.formatMessage(messages.individualEmailsLabelLearnersInputPlaceholder)} | ||
| onChange={handleSelectedLearnerEmail} | ||
| renderMenuItemChildren={({ name, email, username }) => ( | ||
| <span data-testid="autocomplete-email-option">{name ? `${name} -` : name} {username ? `${username} -` : username} {email}</span> |
There was a problem hiding this comment.
In the case the variables doesn't exist the value should be an empty string, not the variable
AuraAlba
reviewed
Dec 29, 2023
| /> | ||
| {emailList.length > 0 && ( | ||
| <Container className="email-list"> | ||
| <Form.Label className="col-12" data-testid="learners-email-list-label">{intl.formatMessage(messages.individualEmailsLabelLearnersListLabel)}</Form.Label> |
There was a problem hiding this comment.
Suggested change
| <Form.Label className="col-12" data-testid="learners-email-list-label">{intl.formatMessage(messages.individualEmailsLabelLearnersListLabel)}</Form.Label> | |
| <Form.Label className="col-12" data-testid="learners-email-list-label"> | |
| {intl.formatMessage(messages.individualEmailsLabelLearnersListLabel)} | |
| </Form.Label> |
AuraAlba
reviewed
Dec 29, 2023
| width: 100%; | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| border: 1px solid #ccc; |
There was a problem hiding this comment.
Manage colors as variables. If they are be used in other components, make a separate file
|
Hi @johnvente, I tested the changes, and work correctly! 💯 |
BryanttV
approved these changes
Dec 29, 2023
johnvente
force-pushed
the
jv/feat-send-indivudial-email-pluggable
branch
from
381cfd2 to
2884398
Compare
johnvente
force-pushed
the
jv/feat-send-indivudial-email-pluggable
branch
from
2884398 to
a6dfabb
Compare
AuraAlba
approved these changes
Jan 2, 2024
johnvente
force-pushed
the
jv/pluggable-component-slot
branch
2 times, most recently
from
2b8e68b to
0d94489
Compare
johnvente
force-pushed
the
jv/pluggable-component-slot
branch
2 times, most recently
from
e3e2ce8 to
ffa1797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature will allow sending emails to expected emails of students in the course using pluggable component
Demo
Plugin loaded:
How to test it
If you are using devstack
Go to http://localhost:1984/courses/course-v1:edX+DemoX+Demo_Course/bulk_email Or
http://localhost:1984/courses/{{id_course}}/bulk_email
Select the checkbox called "Individual learners"
In the input with this label "Add individual learner" search an student with email/name/username and click on the user that you wish
Fill out the fields Subject and Body