Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for escaped special characters in glob expressions #26

Open
rakus opened this issue Apr 21, 2019 · 2 comments
Open

Tests for escaped special characters in glob expressions #26

rakus opened this issue Apr 21, 2019 · 2 comments

Comments

@rakus
Copy link

rakus commented Apr 21, 2019

The editorconfig home page, section File Format Details says:

Special characters can be escaped with a backslash so they won't be interpreted as wildcard patterns.

So from my understanding, the following glob expressions are valid and should be tested.

[a\*.abc]
tab_width=19

[a\?.abc]
tab_width=20

[a\[.abc]
tab_width=21

[a\{.abc]
tab_width=22

I could provide a pull request if you are interested.

PS: The escaped '[' and '{' result in invalid regular expressions in editorconfig-core-py.

@rakus
Copy link
Author

rakus commented Apr 22, 2019

Another glob expression that should be tested:

; Slash after escaped close bracket
[ab[c\]/]d]
slash_after_escaped_close=true

@xuhdev
Copy link
Member

xuhdev commented Jun 30, 2019

Closed the wrong issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants