Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some end to end test that actually hits the S3 upload code #601

Open
rbino opened this issue Sep 20, 2024 · 0 comments
Open

Add some end to end test that actually hits the S3 upload code #601

rbino opened this issue Sep 20, 2024 · 0 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@rbino
Copy link
Collaborator

rbino commented Sep 20, 2024

We already hit a couple of bugs in the upload part of things because S3 upload is stubbed out in tests.

Given that being able to upload a base image is an important piece of functionality that we don't want to regress, we should exercise the actual S3 upload implementation at least with some smoke tests and some local supporting infrastructure (e.g. Minio).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants