Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant reconciler should compare local and reconciled resources on known fields only #531

Open
davidebriani opened this issue May 31, 2024 · 0 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@davidebriani
Copy link
Collaborator

The tenant reconciler ensures that the Astarte resources needed for a tenant to work are correctly installed/updated in the corresponding Astarte realm.

However, when comparing the definition of the desired resource with the already installed resource, Edgehog performs the comparison with a simple equality check ==:

defp trigger_matches?(required, existing) do

This can be problematic if Astarte introduces some new functionalities and fields on resources, so the resource exposed by Astarte contains fields that will never match the definition included in Edgehog: the tenant reconciler would thus continuously reinstall the resource, even if it should not.

@davidebriani davidebriani added the good first issue Good for newcomers label Dec 3, 2024
@davidebriani davidebriani added this to the v0.10 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant