chore(database): Add ssl support #777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build c395699918b813e65764d4f4c2f40f755362a414-PR-777Details
💛 - Coveralls |
noaccOS
reviewed
Dec 16, 2024
lusergit
force-pushed
the
feat/db-ssl
branch
6 times, most recently
from
4f17a38 to
13150b2
Compare
Adds ssl/tls support for the edgehog <-> database communication. Closes edgehog-device-manager#419. Signed-off-by: Luca Zaninotto <[email protected]>
lusergit
force-pushed
the
feat/db-ssl
branch
from
13150b2 to
c395699
Compare
noaccOS
reviewed
Dec 18, 2024
| certfile = System.get_env("DATABASE_SSL_CACERTFILE") | ||
|
|
||
| case {certfile, use_os_certs} do | ||
| {nil, false} -> |
There was a problem hiding this comment.
I don't think we should raise regardless in this condition.
While it is a good idea to handle the situation, given that we can inform the user about the correct environment variables to set, the user may also just want to use :verify_none, in which case it does not need to set them
There was a problem hiding this comment.
Maybe I should have made this a private function, but this gets called only from line 172, so only if the user explicitly set DATABASE_SSL_VERIFY=true, in that case the configuration requires either a valid certificate or to use the os certificates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ssl/tls support for the edgehog <-> database communication.
Closes #419.