Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in getPage callback causes the verification grid to hard fail #235

Open
hudson-newey opened this issue Oct 31, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@hudson-newey
Copy link
Member

Because the getPage callback is user-supplied, we cannot guarantee that it will not be falkey

However, if the getPage callback does throw an error, we currently hard-fail and the verification grid will be left in an unknown (sometimes unresponsive) partial state.

We should catch getPage errors, raise them, and retry to fetch after a certain timeout or a page of results has been verified.

@hudson-newey hudson-newey added the bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant