Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid size controls should have an upper limit based on screen/container size #195

Open
hudson-newey opened this issue Sep 26, 2024 · 1 comment
Labels
enhancement New feature or request ui

Comments

@hudson-newey
Copy link
Member

Currently, the control to change the verification grid size has a fixed maximum of 36.

This is irrespective of the user's screen size and the size of the verification grid container.

This means that users can see and set grid sizes that are unreasonable.
e.g. A mobile user can set a grid size of 36


To fix this, the dynamic-grid-size.ts class should advertise the maximum number of grid cells that can fit in the verification grid's container.

@hudson-newey
Copy link
Member Author

Included in this issue:
If the grid size is forcefully increased past the screen maximum (by manually overriding the grid-size HTML attribute) we should display a warning that some items have been truncated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui
Projects
None yet
Development

No branches or pull requests

1 participant