Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce separate layer to handle serialization and deserialization #60

Open
Ozaq opened this issue Dec 11, 2024 · 0 comments
Open

Introduce separate layer to handle serialization and deserialization #60

Ozaq opened this issue Dec 11, 2024 · 0 comments

Comments

@Ozaq
Copy link
Contributor

Ozaq commented Dec 11, 2024

With the introduction of remote FDB we have a few places where we serialize and deserialize in the same code that is doing some higher level logic.

We need to reevaluate the current implementation and explore if we should introduce an abstraction over the serialization/deserialization code with the goal to hide future protocol changes from the calling code.

See RemoteFDB::RemoteFDB for an example, we construct the bytebuffer and build the message byte by byte directly. IMO the code here operates on very different levels of abstraction and should be separated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant