Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CFMessage conversion methods and tests #9

Open
7 tasks
RobertRosca opened this issue Jul 12, 2020 · 0 comments
Open
7 tasks

Add missing CFMessage conversion methods and tests #9

RobertRosca opened this issue Jul 12, 2020 · 0 comments

Comments

@RobertRosca
Copy link
Contributor

Should probably implement these two functions, although they're only used when saving data, which is not done yet:

  • to_grib_step
  • to_grib_date_time

Need to add:

  • Specific tests for these functions
    • Maybe parity tests with python implementation again?

Need to investigate:

  • from_grib_step application, the method seems correct however applying it results in different values from the python implementation
  • Is it actually worth doing the type-dispatch method for from_grib_date_time? It's not too important, and makes the code more difficult to read through
  • Better implementation of read_message? Not the most elegant solution, something better must be out there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant