Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve plugin compatibility check #1584

Open
milyin opened this issue Nov 6, 2024 · 0 comments
Open

improve plugin compatibility check #1584

milyin opened this issue Nov 6, 2024 · 0 comments
Labels
new feature Something new is needed

Comments

@milyin
Copy link
Contributor

milyin commented Nov 6, 2024

Describe the feature

Currently plugin version verification checks rust compiler version, features enabled and zenoh structures version (see plugins/zenoh-plugin-trait/src/compatibility.rs)
It's known that this information is not enough to guarantee compatibility, but on the other hand the full guarantee should include e.g. total equivalence of versions of all crates used, which seems too strict. But at least some crates versions need to be verified. This is report from @Charles-Schleich about zenoh-ts:

it looks like websocket connection failure during the meeting was completely unrelated to the actual connection:
I was building the plugin targeting 1.0.1 , with running zenohd 1.0.0-beta4, and the tokio executor wasn't progressing the Websocket task forward.
Updating everything to 1.0.1 seems to have fixed the issue.

We need to add list of crates which versions should match. This list will definitely include zenoh itself and tokyo

@milyin milyin added the new feature Something new is needed label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Something new is needed
Projects
None yet
Development

No branches or pull requests

1 participant