Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused items in zenoh-plugin-storage-manager #1580

Open
fuzzypixelz opened this issue Nov 5, 2024 · 0 comments
Open

Unused items in zenoh-plugin-storage-manager #1580

fuzzypixelz opened this issue Nov 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@fuzzypixelz
Copy link
Member

Describe the bug

warning: unused import: `PluginDiff`
  --> zenoh/src/net/runtime/adminspace.rs:25:41
   |
25 | use zenoh_plugin_trait::{PluginControl, PluginDiff, PluginStatus};
   |                                         ^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused variable: `active_plugins`
   --> zenoh/src/net/runtime/adminspace.rs:212:17
    |
212 |         let mut active_plugins = runtime
    |                 ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_active_plugins`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: variable does not need to be mutable
   --> zenoh/src/net/runtime/adminspace.rs:212:13
    |
212 |         let mut active_plugins = runtime
    |             ----^^^^^^^^^^^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

   Compiling zenoh_backend_traits v1.0.0-dev (/home/mahmoud/source/zenoh/plugins/zenoh-backend-traits)
   Compiling zenoh-plugin-storage-manager v1.0.0-dev (/home/mahmoud/source/zenoh/plugins/zenoh-plugin-storage-manager)
warning: associated function `start_plugin` is never used
  --> zenoh/src/net/runtime/adminspace.rs:99:8
   |
97 | impl AdminSpace {
   | --------------- associated function in this implementation
98 |     #[cfg(feature = "plugins")]
99 |     fn start_plugin(
   |        ^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

To reproduce

  1. cargo build --package zenoh-plugin-storage-manager

System info

@fuzzypixelz fuzzypixelz added the bug Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant