Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated validation endpoint #909

Closed
kilianus777 opened this issue Dec 6, 2023 · 3 comments · Fixed by #937
Closed

Deprecated validation endpoint #909

kilianus777 opened this issue Dec 6, 2023 · 3 comments · Fixed by #937
Labels
bug Something isn't working triage all new issues awaiting classification

Comments

@kilianus777
Copy link

Describe the bug

The memory chart references and creates a validation endpoint and service.
Afaik this endpoint is not available anymore and results in a 404 error during token validation.

To Reproduce

  1. Deploy the default edc memory chart two times
  2. Try a data transfer between the two EDCs
  3. Fails with 404 by the token transfer endpoint

Expected behavior

The template of the "normal" chart uses the CONTROL_PATH and CONTROL_PORT instead.
After manually changing the EDC_DATAPLANE_TOKEN_VALIDATION_ENDPOINT to the control endpoint, the transfer succeeds.

Context Information

  • Used version: chart 0.5.3

Possible Implementation

I guess the fix would be to use the same template as in the "normal" chart.
But I wanted to confirm, before I create a PR.

@kilianus777 kilianus777 added bug Something isn't working triage all new issues awaiting classification labels Dec 6, 2023
@ndr-brt
Copy link
Contributor

ndr-brt commented Dec 14, 2023

Hey, if you have a PR ready please feel free to open it

@KilianHaag
Copy link
Contributor

Hey @ndr-brt, is it possible to reopen the PR or should I consider this as rejected?

@ndr-brt
Copy link
Contributor

ndr-brt commented Jan 8, 2024

re-opened it, it just fell off ignored. I will add reviewers so that won't happen again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage all new issues awaiting classification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants