Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4345] Make table cells independently selectable #4350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[4345] Make table cells independently selectable #4350

wants to merge 1 commit into from

Conversation

frouene
Copy link
Contributor

@frouene frouene commented Dec 30, 2024

Bug: #4345

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Architectural decision records (ADR)

  • Does the title of the commit contributing the ADR start with [doc]?
  • Are the ADRs mentioned in the relevant section of the CHANGELOG.adoc?

Dependencies

  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • Are the new dependencies justified in the CHANGELOG.adoc?

Frontend

This section is not relevant if your contribution does not come with changes to the frontend.

General purpose

  • Is the code properly tested? (Plain old JavaScript tests for business code and tests based on React Testing Library for the components)

Typing

We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).

  • Variables have a proper type
  • Functions’ arguments have a proper type
  • Functions’ return type are specified
  • Hooks are properly typed:
    • useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
    • useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
    • useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
    • useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
    • useState<STATE_TYPE>(…)
  • All components have a proper typing for their props
  • No useless optional chaining with ?. (if the GraphQL API specifies that a field cannot be null, do not treat it has potentially null for example)
  • Nullable values have a proper type (for example let diagram: Diagram | null = null;)

Backend

This section is not relevant if your contribution does not come with changes to the backend.

General purpose

  • Are all the event handlers tested?
  • Are the event processor tested?
  • Is the business code (services) tested?
  • Are diagram layout changes tested?

Architecture

  • Are data structure classes properly separated from behavioral classes?
  • Are all the relevant fields final?
  • Is any data structure mutable? If so, please write a comment indicating why
  • Are behavioral classes either stateless or side effect free?

Review

How to test this PR?

Please describe here the various use cases to test this pull request

  • Has the Kiwi TCMS test suite been updated with tests for this contribution?

@frouene frouene added this to the 2025.2.0 milestone Dec 30, 2024
@frouene frouene requested a review from AxelRICHARD as a code owner December 30, 2024 09:11
@frouene frouene linked an issue Dec 30, 2024 that may be closed by this pull request
Selection on table should be differentiated between the row and its cells #4345
Open
sbegaudeau
sbegaudeau requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@sbegaudeau sbegaudeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the modified files are not related to the issue being treated

packages/tables/frontend/sirius-components-tables/src/table/TableContent.types.ts Outdated
@@ -25,7 +25,7 @@ export interface TableProps {
enableColumnFilters: boolean;
enableRowSizing: boolean;
enableGlobalFilter: boolean;
enablePagination: boolean;
enableCursorBasedPagination: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of this change? Not only it's not related to the issue being treated but I fail to see what value does it bring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to a separate PR

packages/tables/frontend/sirius-components-tables/src/cells/Cell.tsx Outdated
Comment on lines 39 to 43
const useStyles = makeStyles()(() => ({
cell: {
width: '100%',
},
}));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's odd, why are you layouting things in the children instead of its parent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the behavior in the parent useTableColumns

packages/tables/frontend/sirius-components-tables/src/columns/useTableColumnFiltering.ts Outdated
@@ -81,7 +81,7 @@ export const useTableColumnFiltering = (

if (!enableColumnFilters) {
return {
columnFilters: undefined,
columnFilters: [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to a separate PR

@frouene
Copy link
Contributor Author

frouene commented Jan 3, 2025

Most of the modified files are not related to the issue being treated

Ok, I will move these changes to specific PR

@frouene frouene force-pushed the fro/enh/table-cell-selection branch from 4078b91 to b4a92ec Compare January 3, 2025 10:00
@frouene frouene force-pushed the fro/enh/table-cell-selection branch from b4a92ec to e3f4a22 Compare January 3, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbegaudeau sbegaudeau sbegaudeau requested changes

@AxelRICHARD AxelRICHARD Awaiting requested review from AxelRICHARD

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pr: to review soon priority: low
Projects
None yet
Milestone
2025.2.0
Development

Successfully merging this pull request may close these issues.

Selection on table should be differentiated between the row and its cells
2 participants
@frouene @sbegaudeau