Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties Panel Validation bug when using Group Extensions #450

Open
Greglar4 opened this issue Sep 4, 2024 · 0 comments
Open

Properties Panel Validation bug when using Group Extensions #450

Greglar4 opened this issue Sep 4, 2024 · 0 comments

Comments

@Greglar4
Copy link

Greglar4 commented Sep 4, 2024

I think I have found a bug regarding properties panel validations when using group extensions. When adding a validation to a widget in the parent group, the validation never appears in the parent group, while the validation and tool-tip is duplicated in the child group.

To reproduce, take the Sirius tutorial Family example. Add a properties panel Page containing two groups. The first group should be for the basicfamily::Person domain class. Add a text widget that displays the Person's name. Then, create a second group which extends the first group, and which is for the basicfamily::Man domain class. Then, add a validation in the Person group which is for the name text widget. For these purposes, set the audit to always return false so the validation is always shown.

Run the example and import the sample basic family from the tutorial. When clicking on the people you will notice that for the Men and Women nodes, the name text widget in the Person group does not have a validation marker. Second, when looking at the name text widget in the Man group, you will see that the tool-tip for the validation displays the validation message twice. The properties panel will show that 2 messages are detected, which seems to me to imply that both validations are being assigned to the Man group text widget, instead of one to the Person group text widget and one to the Man group text widget.

I would expect that when adding a validation to a widget in a group that is then extended, that this validation would apply to the widget in the group itself, as well as to all of the same widgets that appear in any group that extends that group. It is possible though that I am misunderstanding something about how validations work in regards to group extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant