Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #518 (Setting a breakpoint inside lambda with object). #523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nettozahler
Copy link

What it does

Fixes #518

How to test

Try to set a breakpoint inside a lambda expression with its body beginning with an anonymous class declaration.
See #518 as example. The new breakpoint should appear as usual and jumping to it from inside the "breakpoint view" must work.

Author checklist

@nettozahler nettozahler marked this pull request as draft October 1, 2024 13:43
@nettozahler
Copy link
Author

Maybe it would be good to extend the existing tests for this case.

@nettozahler
Copy link
Author

Review should consider this:
Lambda body can be a block or an (arbitrary) expression. So maybe the cases which are handled in the code are insufficient and should be replaced by handling the general org.eclipse.jdt.core.dom.Expression (see my similar comment in changed Java file).

@nettozahler nettozahler marked this pull request as ready for review October 2, 2024 12:34
@jukzi
Copy link
Contributor

jukzi commented Nov 7, 2024

please add a junit test. see /org.eclipse.jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/breakpoints for related ones

@nettozahler
Copy link
Author

Hi, @jukzi, I would try to craft a PR with a JUnit test but first I need a hint to make my Eclipse SDK working again. My initial setup with OOMPH was fine and I used it for several months. Now I have updated the SDK with the "Perform setup tasks" feature. After this I now have zillions of compile errors in my SDK because all/many of the external dependencies like JSoup are missing. How can I restore/recreate all these dependencies to get rid of the compile errors? Thanks in advance.

@jukzi
Copy link
Contributor

jukzi commented Nov 14, 2024

When i have such problems it helps to 1. pull all repositories, 2. use the "edit" button of the eclipse-sdk target platform to update it. 3. reload the active target platform. 4. rebuild all projects. Don't know why such is not done automatically @merks

@merks
Copy link
Contributor

merks commented Nov 14, 2024

Help -> Perform Setup Tasks... should generally update everything after pulling all the git repositories. The *.target file should be resolved automatically by those steps, but for unknown reasons (in PDE) that doesn't always work. :-(

@nettozahler
Copy link
Author

Thanks for the quick response with valuable hints from experienced Eclipse developers. But they have produced some big question marks on my face. As you can see I need some more detailed info. Let's go through the steps.

  1. Pull all repos: "Perform Setup Tasks" does this and I can also do it manually. CHECK
  2. use the "edit" button of the eclipse-sdk target platform to update it: Where is this button located? Inside Eclipse? Never seen this before.
  3. reload the active target platform: How to do this?
  4. rebuild all projects: Have done this zillions of times before. CHECK

@jukzi
Copy link
Contributor

jukzi commented Nov 14, 2024

windows/preference:
image

@nettozahler
Copy link
Author

Thanks. This procedure helped me out and resolved my compile errors. :)

@nettozahler
Copy link
Author

Now I added a JUnit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a breakpoint inside a lamda that contains an object fails
3 participants