Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows VM on github workflows #165

Open
jeyvison opened this issue Dec 12, 2022 · 2 comments
Open

Windows VM on github workflows #165

jeyvison opened this issue Dec 12, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low-priority Low priority issue

Comments

@jeyvison
Copy link
Contributor

jeyvison commented Dec 12, 2022 •
edited
Loading

We recently had an issue that only applied to Windows(#162) so it would be good if we had windows images on the workflows besides the linux images we're using.
@jeyvison jeyvison added enhancement New feature or request good first issue Good for newcomers labels Dec 12, 2022
@m-reza-rahman m-reza-rahman added low-priority Low priority issue help wanted Extra attention is needed labels Oct 6, 2023
@Aditya-Guntur
Copy link

Hey, is the problem still relevant? I'd like to work on it.

@m-reza-rahman
Copy link
Contributor

This was pretty early on. I would say you should first review the code and see if this is relevant any more. I don’t think we have much OS specific code if any. If it is, it’ll be good if we can mix in Windows in one of the two workflows. Duplicating things just for Windows seems a bit overkill to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low-priority Low priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeyvison @m-reza-rahman @Aditya-Guntur