Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing kid when resolving DIDs with multiple keys should fail #3649

Closed
paullatzelsperger opened this issue Nov 23, 2023 · 0 comments · Fixed by #3655
Closed

Missing kid when resolving DIDs with multiple keys should fail #3649

paullatzelsperger opened this issue Nov 23, 2023 · 0 comments · Fixed by #3655
Assignees
@paullatzelsperger
Labels
breaking-change Will require manual intervention for version update bug_report Suspected bugs, awaiting triage dcp
Milestone
Milestone 13

Comments

@paullatzelsperger
Copy link
Member

Bug Report

Describe the Bug

When resolving public keys from DID documents (e.g. SelfIssuedTokenVerifier), the current implementation takes the kid ("key-id") to resolve the verification method from the did.
If the kid is null, the first verification method is resolved.

This is incorrect.

Expected Behavior

If kid == null, and the DID only contains one verification method, return it.
If kid != null, and the DID contains a verification method with that ID, return it.

In all other cases, return an error.
@paullatzelsperger paullatzelsperger added bug_report Suspected bugs, awaiting triage dcp breaking-change Will require manual intervention for version update labels Nov 23, 2023
@paullatzelsperger paullatzelsperger self-assigned this Nov 23, 2023
@paullatzelsperger paullatzelsperger added this to the Milestone 13 milestone Nov 24, 2023
@paullatzelsperger paullatzelsperger mentioned this issue Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paullatzelsperger paullatzelsperger

Labels
breaking-change Will require manual intervention for version update bug_report Suspected bugs, awaiting triage dcp
Projects
None yet
Milestone
Milestone 13
Development

Successfully merging a pull request may close this issue.

fix: require key-id when resolving key material paullatzelsperger/DataSpaceConnector
1 participant
@paullatzelsperger