Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Break coupling between identity-trust-spi and json-ld-spi #3579

Closed
jimmarino opened this issue Oct 30, 2023 · 0 comments · Fixed by #3580
Closed

chore: Break coupling between identity-trust-spi and json-ld-spi #3579

jimmarino opened this issue Oct 30, 2023 · 0 comments · Fixed by #3580
Assignees
@jimmarino
Labels
refactoring Cleaning up code and dependencies

Comments

@jimmarino
Copy link
Contributor

Module identity-trust-spi depends on son-ld-spi for the @type and @id keyword constants but does not require any functionality from that module. This dependency should be broken, as those two keywords will never change and are already have constants defined in the identity-trust-spi module.
@jimmarino jimmarino added the refactoring Cleaning up code and dependencies label Oct 30, 2023
@jimmarino jimmarino self-assigned this Oct 30, 2023
@jimmarino jimmarino changed the title chore: Break coupling between identity-trust-spi and 'json-ld-spi` chore: Break coupling between identity-trust-spi and json-ld-spi Oct 30, 2023
@jimmarino jimmarino mentioned this issue Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmarino jimmarino

Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Break coupling between identity-trust-spi and json-ld-spi jimmarino/DataSpaceConnector
1 participant
@jimmarino