You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Support for in-application API version 1.4.1 was introduced in #91, which included the renaming of shutdown to remove_hooks. This rename cannot be handled the same way as previous renames, where the old method can be retroactively marked deprecated if the requested API version is 1.4.1 or higher, because both of these methods take an owned self.
This means that the existing Deref and DerefMut implementations for RenderDoc<V> aren't sufficient for either method to work properly, and it would require a DerefMove trait to be added to the standard library (see rust-lang/rfcs#997 for details).
For now, as per #92, the remove_hooks() method is not available to call, even if RenderDoc<V141> is selected at compile-time. In the future, once DerefMove is added to Rust or an alternative solution can be found, we will be able to restore the full set of changes from #91 and expose both remove_hooks and shutdown correctly.
The text was updated successfully, but these errors were encountered:
After reviewing this code years later after having written it, this entire library looks incredibly sketchy (abuse of the Deref and DerefMut traits for odd purposes, sound but still unnecessary uses of std::mem::transmute(), and a few other things) and isn't exactly something I'm proud of. I think this entire API warrants a rewrite with a few long-standing bugs fixed.
Support for in-application API version 1.4.1 was introduced in #91, which included the renaming of
shutdown
toremove_hooks
. This rename cannot be handled the same way as previous renames, where the old method can be retroactively marked deprecated if the requested API version is 1.4.1 or higher, because both of these methods take an ownedself
.This means that the existing
Deref
andDerefMut
implementations forRenderDoc<V>
aren't sufficient for either method to work properly, and it would require aDerefMove
trait to be added to the standard library (see rust-lang/rfcs#997 for details).For now, as per #92, the
remove_hooks()
method is not available to call, even ifRenderDoc<V141>
is selected at compile-time. In the future, onceDerefMove
is added to Rust or an alternative solution can be found, we will be able to restore the full set of changes from #91 and expose bothremove_hooks
andshutdown
correctly.The text was updated successfully, but these errors were encountered: